You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix the archer base damage step at levels 6, 16, ... 96 - #171
The archer column of DamageService gave the level 6 step +1 and the level 7 step +2. The game does it the other way round: the step is 1 when i % 10 is 1, 3, 6 or 8. As a result, every level ending in 6 was one point low.
I checked the column against the game's damage results at every level from 1 to 99. With this fix, all 99 levels match. Before it, the ten levels 6, 16, … 96 were each one point short. The approval table is updated to match.
The archer column gained 1 instead of 2 on the level 6 step and 2 instead
of 1 on the level 7 step, so every level ending in 6 was one point low.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkUgtue8mHJ8prh9NdK
No actionable comments were generated in the recent review.
Walkthrough
The Archer minimum-damage increment condition changes from level remainder 5 to remainder 6. The approved damage documentation increases the listed Archer values by 1 at levels 6, 16, 26, 36, 46, 56, 66, 76, 86, and 96.
Changes
Archer damage
Layer / File(s)
Summary
Update increment condition and documented values src/NosCore.Algorithm/DamageService/DamageService.cs, documentation/DocumentationTest.DamageDocumentation.approved.md
The increment condition uses remainder 6 instead of remainder 5 for an increment of 1. The documented Archer damage values at levels 6 through 96 in steps of 10 each increase by 1.
This corrects the Archer base damage at levels ending in 6 so it matches the game's results, and the approval table is updated to match. No merge-blocking risk is identified.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the archer base damage step fix at levels 6, 16, ... 96, which matches the DamageService change (remainder 6 instead of 5 in the Archer increment condition) and the approved documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the archer base damage step fix at levels 6, 16, ... 96, which matches the DamageService change (remainder 6 instead of 5 in the Archer increment condition) and the approved documentation update that raises Archer damage by 1 at those levels. The title is concise, specific, and reflects the primary change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of NosCoreIO/NosCore#2847
The archer column of
DamageServicegave the level 6 step +1 and the level 7 step +2. The game does it the other way round: the step is 1 wheni % 10is 1, 3, 6 or 8. As a result, every level ending in 6 was one point low.I checked the column against the game's damage results at every level from 1 to 99. With this fix, all 99 levels match. Before it, the ten levels 6, 16, … 96 were each one point short. The approval table is updated to match.
Generated by Claude Code
Summary by CodeRabbit